simon987/task_tracker
1
0
Fork 0
mirror of https://github.com/simon987/task_tracker.git synced 2025-04-19 18:16:45 +00:00
Code Issues Projects Releases Wiki Activity

Don't use transaction in bulk insert

Browse Source
This commit is contained in:
simon987 2019-04-11 21:51:07 -04:00
parent 27fcf28923
commit 8f10567bd0
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
storage/task.go
View File

@ -78,16 +78,10 @@ func (database Database) BulkSaveTask(bulkSaveTaskReqs []SaveTaskRequest) []erro
db := database.getDB() db := database.getDB()
tx, err := db.Begin()
if err != nil {
handleErr(err)
return nil
}
errs := make([]error, len(bulkSaveTaskReqs)) errs := make([]error, len(bulkSaveTaskReqs))
for i, req := range bulkSaveTaskReqs { for i, req := range bulkSaveTaskReqs {
res, err := tx.Exec(fmt.Sprintf(` res, err := db.Exec(fmt.Sprintf(`
INSERT INTO task (project, max_retries, recipe, priority, max_assign_time, hash64,verification_count) INSERT INTO task (project, max_retries, recipe, priority, max_assign_time, hash64,verification_count)
SELECT $1,$2,$3,$4,$5,NULLIF(%d, 0),$6 FROM worker_access SELECT $1,$2,$3,$4,$5,NULLIF(%d, 0),$6 FROM worker_access
WHERE role_submit AND NOT request AND worker=$7 AND project=$1`, req.Hash64), WHERE role_submit AND NOT request AND worker=$7 AND project=$1`, req.Hash64),
@ -96,12 +90,13 @@ func (database Database) BulkSaveTask(bulkSaveTaskReqs []SaveTaskRequest) []erro
req.WorkerId) req.WorkerId)
errs[i] = err errs[i] = err
if res != nil {
rowsAffected, _ := res.RowsAffected() rowsAffected, _ := res.RowsAffected()
if rowsAffected == 0 { if rowsAffected == 0 {
errs[i] = errors.New("unauthorized task submit") errs[i] = errors.New("unauthorized task submit")
} }
} }
_ = tx.Commit() }
return errs return errs
} }