From b1da29d7fbc23e5022d69a05ab6231cb56809a5e Mon Sep 17 00:00:00 2001 From: Kevin Ramharak Date: Wed, 23 Jan 2019 09:16:44 +0100 Subject: [PATCH] fix feedback --- .../server/assembly/instruction/SetccInstruction.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Server/src/main/java/net/simon987/server/assembly/instruction/SetccInstruction.java b/Server/src/main/java/net/simon987/server/assembly/instruction/SetccInstruction.java index 07a2aef..db8f863 100644 --- a/Server/src/main/java/net/simon987/server/assembly/instruction/SetccInstruction.java +++ b/Server/src/main/java/net/simon987/server/assembly/instruction/SetccInstruction.java @@ -21,9 +21,6 @@ import java.util.HashMap; * Implementation of the SETcc family of instructions * http://www.ousob.com/ng/iapx86/ng22d84.php * - * - * Stuff to consider - * - move the implementation of each instruction to its own class that extends this class */ public class SetccInstruction extends Instruction { @@ -71,7 +68,7 @@ public class SetccInstruction extends Instruction { } /** - * The SET instructions set the 8-bit destination to 1 if the + * The SET instructions set the 16-bit destination to 1 if the * specified condition is true, otherwise destination is set to 0. * * FamilyOpcode Instruction SET to 1 if ... else to 0 Flags @@ -145,7 +142,7 @@ public class SetccInstruction extends Instruction { /** * Encodes the instruction. Writes the result in the outputStream. - * Needs one operand of OperandType.REGISTER or OperandType. + * Needs one operand of OperandType.REGISTER or OperandType.MEMORY_REG16 * * @param out encoded bytes will be written here */