From 080266ac4a38ddf83c4b072cc1c4ae12925dbf16 Mon Sep 17 00:00:00 2001 From: jacquej96 <32223123+jacquej96@users.noreply.github.com> Date: Wed, 16 Oct 2019 08:25:01 -0400 Subject: [PATCH] Resolved PR comments Explicitly declared i in loop, handled result === undefined, removed unnecessary empty string initialization. --- Server/src/main/resources/static/js/editor.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Server/src/main/resources/static/js/editor.js b/Server/src/main/resources/static/js/editor.js index 6f08dc4..d95f00c 100644 --- a/Server/src/main/resources/static/js/editor.js +++ b/Server/src/main/resources/static/js/editor.js @@ -176,7 +176,9 @@ function parseDWInstruction(line, result, currentLine) { } function isLabel(text, result) { - for (i = 0; i < result.labels.length; i++) { + if (result === undefined) { return false; } + + for (var i = 0; i < result.labels.length; i++) { if (text === result.labels[i]) { return true; } @@ -201,7 +203,7 @@ function isRegisterOp(text) { function getOffsetOperandType(text) { - var offset = ""; + var offset; if (isRegisterOp(text.substring(0, 2))) { offset = text.substring(2); } else if (isRegisterOp(text.substring(0, 1))) {